Feat/lmstudio integration #13557
Merged
Feat/lmstudio integration #13557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:L
| for message in messages | ||
| ], | ||
| "options": self._model_kwargs, | ||
| "stream": False, |
There was a problem hiding this comment.
stream is hardcoded to false here (I think we want to pass this in?)
There was a problem hiding this comment.
It is not actually hardcoded. We can override the value by passing an argument in the function. In the returned dictionary, **kwargs will include all keyword arguments that are not explicitly listed in the function signature. If any of these keyword arguments match the keys in the dictionary, they will override the hardcoded values.
llama-index-integrations/llms/llama-index-llms-lmstudio/llama_index/llms/lmstudio/base.py
Outdated
Show resolved
Hide resolved
logan-markewich
approved these changes
May 20, 2024
shivamklr
force-pushed
the
feat/lmstudio-integration
branch
from
922b577
to
339489b
Compare
dosubot
bot
added
size:XL
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@logan-markewich Let me know if we have additional requirements before the merge into main. |
logan-markewich
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Support for LM Studio
Resolves #13556
New Package?
Did I fill in the
tool.llamahubsection in thepyproject.tomland provide a detailed README.md for my new integration or package?Version Bump?
Did I bump the version in the
pyproject.tomlfile of the package I am updating? (Except for thellama-index-corepackage)Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Suggested Checklist:
make format; make lintto appease the lint gods