Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OutputMatcher should take a Collection rather than a List #22756

Open
elharo opened this issue May 15, 2024 · 3 comments · May be fixed by #22786
Open

OutputMatcher should take a Collection rather than a List #22756

elharo opened this issue May 15, 2024 · 3 comments · May be fixed by #22786

Comments

@elharo
Copy link
Contributor

elharo commented May 15, 2024

com.facebook.presto.sql.planner.assertions.OutputMatcher should take a Collection rather than a List

Order is not important in this class so this is semantically correct, and I encountered a case where it would have been mildly more convenient to pass in a Set instead of a List.

@elharo elharo changed the title OutputMatcher should takae Collection rather than a List OutputMatcher should take a Collection rather than a List May 15, 2024
@wonderfulvamsi
Copy link

wonderfulvamsi commented May 15, 2024

Hi @elharo and @tdcmeehan I'm new to open source, I'm interning at a company that uses Presto.
This looks like a doable good first issue for me.
Can you please assgine me this?

@wonderfulvamsi
Copy link

Hi @elharo I just completed my presto local setup and had a look at the code.

OutputMatcher is being used in a method called withOutput in PlanMatchPattern class.
So i made the code changes in those files.

I did the maven build with tests it was successful.
Let me know if you want me to add any new tests or shall i proceed with the PR.

@elharo
Copy link
Contributor Author

elharo commented May 18, 2024

aend a PR. It's how we review.

@wonderfulvamsi wonderfulvamsi linked a pull request May 19, 2024 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants