.bp5-popover-target inside label.bp5-label given unnecessary 5px top margin

[evansjohnson]

Environment

• Package version(s): blueprint 5
• Operating System: n/a
• Browser name and version: n/a

Code Sandbox

Link to a minimal repro (fork this code sandbox): TODO

Steps to reproduce

Due to this style:

blueprint/packages/core/src/components/popover/_popover-in-label.scss

Line 9 in 488658d

margin-top: $pt-grid-size * 0.5;

Actual behavior

5px top margin always added to popover targets inside labels

Expected behavior

This top margin should either not be applied as a Blueprint default, or only be applied when relevant. Ex if a popover target is the only or first element in a label, this style is likely undesirable.

Possible solution

Remove, or otherwise make more targeted (perhaps at least :not(:first-child)), this top margin in a major version of Blueprint as this will be a breaking change.

The :not(:first-child) targeting still would not help with the case where a popover target is being placed inline next to an element in a label.