Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new Tabs option to enable tab navigation to non-active tabs #6802

Closed
wants to merge 1 commit into from
Closed

Add new Tabs option to enable tab navigation to non-active tabs #6802

wants to merge 1 commit into from

Conversation

evansjohnson
Copy link
Contributor

Fixes #6759

Note that current behavior follows the W3 guidance for the tabs pattern, so we should consider closing out the filed issue without making any fixes or adding any features. At a minimum, I think the default behavior should follow the guidance, possibly with an opt-in option to add this additional tab navigation pattern to use as consumers of the Tabs component feels is appropriate.

Ex one use case for this is if the usage of the Tabs component, for whatever reason, feels or looks more like a button group, and users expect to be able to tab to all tabs.

Checklist

Can consider tests pending decision to support or not

  • Includes tests
  • Update documentation

Changes proposed in this pull request:

  • Add a new prop enableTabbedNavigation to the Tabs component, which allows using the tab key to access non-active tabs

Reviewers should focus on:

  • Do we want to add this option?
  • Prop naming - also considered insertNonActiveTabsInTabOrder and addNonActiveTabsToTabOrder

Screenshot

Screenshot 2024-05-15 at 2 04 05 PM

@changelog-app
Copy link

changelog-app bot commented May 15, 2024 •
edited by evansjohnson

Generate changelog in packages/core/changelog/@unreleased

What do the change types mean?
  • feature: A new feature of the service.
  • improvement: An incremental improvement in the functionality or operation of the service.
  • fix: Remedies the incorrect behaviour of a component of the service in a backwards-compatible way.
  • break: Has the potential to break consumers of this service's API, inclusive of both Palantir services
    and external consumers of the service's API (e.g. customer-written software or integrations).
  • deprecation: Advertises the intention to remove service functionality without any change to the
    operation of the service itself.
  • manualTask: Requires the possibility of manual intervention (running a script, eyeballing configuration,
    performing database surgery, ...) at the time of upgrade for it to succeed.
  • migration: A fully automatic upgrade migration task with no engineer input required.

Note: only one type should be chosen.

How are new versions calculated?
  • ❗The break and manual task changelog types will result in a major release!
  • 🐛 The fix changelog type will result in a minor release in most cases, and a patch release version for patch branches. This behaviour is configurable in autorelease.
  • ✨ All others will result in a minor version release.

Type

  • Feature
  • Improvement
  • Fix
  • Break
  • Deprecation
  • Manual task
  • Migration

Description

Add new Tabs option to enable tab navigation to non-active tabs

Check the box to generate changelog(s)

  • Generate changelog entry

@invliD
Copy link
Member

invliD commented May 15, 2024

Ah, I was not aware of that guidance when I commented on the issue. Given how explicit the guidance is on this, I'd say we should close it out as wontfix since we currently support that guidance exactly.

@evansjohnson
Copy link
Contributor Author

evansjohnson commented May 15, 2024 •
edited

I agree with leaning towards wontfix, and mostly opened this since it was easy enough to show for consideration

I was stretching a bit with

one use case for this is if the usage of the Tabs component, for whatever reason, feels or looks more like a button group, and users expect to be able to tab to all tabs.

In this case if this isn't the tab navigation pattern you want, then it seems you simply don't want the tabs component

@ericjeney
Copy link
Contributor

+1 to closing this as "won't fix" given the explicitness of the guidance. Thanks, @evansjohnson!

@ericjeney ericjeney closed this May 24, 2024
@ericjeney ericjeney mentioned this pull request May 24, 2024
Closed
@evansjohnson evansjohnson deleted the evanj/tab-through-tabs-option branch May 30, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Domain: accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot use tab key to navigate through Blueprint tabs
3 participants
@evansjohnson @invliD @ericjeney