Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default share expiration cannot be removed when creating a share #45384

Closed
juliushaertl opened this issue May 17, 2024 · 2 comments · Fixed by #45483
Closed

Default share expiration cannot be removed when creating a share #45384

juliushaertl opened this issue May 17, 2024 · 2 comments · Fixed by #45483
Assignees
Labels
1. to develop Accepted and waiting to be taken care of 27-feedback bug

Comments

@juliushaertl
Copy link
Member

Steps to reproduce

  1. Ensure "Set default expiration date for shares" is checked but expiration dates are not enforced
  2. Create a new share to a user through the web UI
  3. Remove the share expiration checkbox
  4. Save the share
  5. Edit the share again

Current behaviour

The expiration date is still set

Expected behaviour

The expiration date is not set as the user removed it

Additional context

It seems the request to create the share doesn't have a expiration date in the request payload but the response is returning it, so either the backend needs some adjustment or the frontend code needs to ensure that a null/empty value is sent along

Affected versions

master to stable27

@juliushaertl juliushaertl added bug 1. to develop Accepted and waiting to be taken care of labels May 17, 2024
@Fenn-CS
Copy link
Contributor

Fenn-CS commented May 17, 2024

Fixed in #44485

@Fenn-CS Fenn-CS linked a pull request May 27, 2024 that will close this issue
2 tasks
@Fenn-CS
Copy link
Contributor

Fenn-CS commented May 27, 2024

#44485 is now merged.

@Fenn-CS Fenn-CS closed this as completed May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of 27-feedback bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants