-
-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Middleware not executed when using exclude
in setGlobalPrefix
#13401
Comments
I have tested the reproduction and confirmed that the issue is only present with So the issue is most likely related to this fix: #13337 |
I think this is caused by #11832, which was intended to address the issue of middleware being called multiple times. However, it filters out some paths. This is effective for Express, but not for Fastify |
Currently still affected by this even with latest nestjs (10.3.8) when using the mikro-orm module |
I wonder if reverting this PR #11832 would fix your issue @eric-deeporigin Would you like to try applying an inline patch just to test it out locally? (open node_modules and revert that change to see if it's causing issues for your project) |
Is there an existing issue for this?
Current behavior
In versions 10.3.4+, if using
exclude
insetGlobalPrefix
, e.g.Then middleware stops being executed at all (any sort of middleware).
For reproduction see tests in https://github.com/xtrinch/nestjs-middleware-issue-demo
Minimum reproduction code
https://github.com/xtrinch/nestjs-middleware-issue-demo
Steps to reproduce
yarn test
, observe that the tests do not pass - middleware should attach a header to requestexclude
param fromsetGlobalPrefix
Expected behavior
Middleware should run regardless of exclude in
setGlobalPrefix
Package
@nestjs/common
@nestjs/core
@nestjs/microservices
@nestjs/platform-express
@nestjs/platform-fastify
@nestjs/platform-socket.io
@nestjs/platform-ws
@nestjs/testing
@nestjs/websockets
Other package
No response
NestJS version
10.3.4+
Packages versions
Node.js version
18
In which operating systems have you tested?
Other
No response
The text was updated successfully, but these errors were encountered: