Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude Orphanet:377788 from rare subset pipeline #7704

Open
joeflack4 opened this issue May 11, 2024 · 3 comments
Open

Exclude Orphanet:377788 from rare subset pipeline #7704

joeflack4 opened this issue May 11, 2024 · 3 comments
Assignees
Labels
bug rare disease tech issue requiring work from the technical team

Comments

@joeflack4
Copy link
Collaborator

Overview

Exclude Orphanet:377788 "Disease" from the rare disease subset generation pipeline.

Context

See this discussion thread:

Nico:

Please exclude

MONDO:0000001 http://purl.obolibrary.org/obo/mondo#ordo_disease Orphanet:377788 disease disease

From the ORDO subset - which is the "ORDO" disorder class itself. Adding this makes the entire ontology become "rare"!

Joe:

Orphanet:377788 "Disease" is a direct subclass of Orphanet:557493 "Disorder", which is one of the subsets that we've selected.

Nico:

I didn't realise "disease" was a subclass of "disorder"... create an issue to... exclude the term from the rare disease subset generation pipeline (with the logic that, while the term is, indeed in the ordo_disorder subset, it should not be added to the rare disease subset, which you are not concerned with here).

@matentzn
Copy link
Member

To be clear, Orphanet:377788 is already excluded from the rare disease subset - this issue is about explicitly excluding it from the rare subset pipeline. Thanks @joeflack4, will take care of it!

@joeflack4 joeflack4 changed the title Exclude Orphanet:377788 from rare disease subset Exclude Orphanet:377788 from rare subset pipeline May 12, 2024
@joeflack4
Copy link
Collaborator Author

Thanks for clarification! I'm completely in the dark on this side of things; those two things sound almost identical. I updated the title~

@matentzn
Copy link
Member

This commit fixes it, and the PR around it will eventually close this issue, when it is merged: 4e98177

@twhetzel twhetzel added the tech issue requiring work from the technical team label May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug rare disease tech issue requiring work from the technical team
Projects
None yet
Development

No branches or pull requests

3 participants