-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can we remove the "in English" link from the editions list on a work page? #9253
Comments
Doesn't this display for every language, not just english? Maybe there's a different function it could be changed to that would be beneficial across languages. |
@stopregionblocking it does show for every language. What function do you propose changing it to? |
I think we just want to remove the link around the language -- not the language text itself. This change seems fine (+1 @mekarpeles , @jimchamp , @scottbarnes ) |
Hello! Could I please work on this issue? |
@jainish2222 yes you're assigned. Good luck! |
I don't see that this is a valuable feature. This is special casing English to be the only language that doesn't get a link. Improving searching by language, or making the language pages more useful for specific tasks would be better features. This will add complexity in a way that doesn't seem generlizable If the website is being viewed in German is it still only English that doesn't have a link? I vote to close this as "not planned" |
Oh to clarify I think the proposal is to remove e.g. the "in English" link. So all the "in {language}" links on the editions table, not specifically the English ones! |
Remove the links to all language pages, but keep the text there? I don't see what that adds either. I guess that's why this is confusing. For the recent work I've been doing on language codes the main way to get to view what languages OL has is by clicking on one of those links and then going back a level to https://openlibrary.org/languages Language is one of the formal OL types https://openlibrary.org/type/language , removing the link will hide the specific catalog code used e.g. |
The reasoning is I believe that clicking on e.g. "English" leads you to the somewhat empty https://openlibrary.org/languages/eng page. It's kind of a strange way to discover the Note the current edition e.g. "English" link will still link to But we also don't link to the e.g. publisher page from the editions table (which is arguably a more useful page). I think the ideal UX for me would probably be:
I think until that larger plan, removing the links seems ok to me, and makes the editions table a little simpler (and also opens the path forward for us to change the behaviour of the link a little more cleanly to filtering the table). But would love to hear others' thoughts as well! |
Having the link that just goes to this page (https://openlibrary.org/languages/eng) and is not useful to patrons as far as I can tell.
Describe the problem that you'd like solved
Proposal & Constraints
I think we should convert it to plain text instead of a hyperlink.
Additional context
Stakeholders
The text was updated successfully, but these errors were encountered: