Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose.yml lists deprecated version tag for Docker v2 #901

Closed
5 tasks done
CollapsingStar opened this issue May 19, 2024 · 0 comments · Fixed by #902
Closed
5 tasks done

docker-compose.yml lists deprecated version tag for Docker v2 #901

CollapsingStar opened this issue May 19, 2024 · 0 comments · Fixed by #902
Labels
bug Something isn't working

Comments

@CollapsingStar
Copy link
Contributor

First Check

  • This is not a feature request
  • I added a very descriptive title to this issue.
  • I used the GitHub search to find a similar issue and didn't find it.
  • I searched the documentation, with the integrated search.
  • I already read the docs and didn't find an answer.

Homebox Version

0.10.3

What is the issue you are experiencing?

The Docker Compose v2 "version: x.x" key/value pair is obsolete according to Docker's spec:

https://github.com/compose-spec/compose-spec/blob/master/spec.md#version-and-name-top-level-elements

I believe the change to the docker-compose.yml (and corresponding setup docs here https://hay-kot.github.io/homebox/quick-start/) should be the following:

Before:

version: "3.4"

services:
  homebox:
    image: homebox
    build:
      context: .
      dockerfile: ./Dockerfile
      args:
        - COMMIT=head
        - BUILD_TIME=0001-01-01T00:00:00Z
    ports:
      - 3100:7745

After:

services:
  homebox:
    image: homebox
    build:
      context: .
      dockerfile: ./Dockerfile
      args:
        - COMMIT=head
        - BUILD_TIME=0001-01-01T00:00:00Z
    ports:
      - 3100:7745

How can the maintainer reproduce the issue?

Reference the Docker setup docs and docker-compose.yml file when setting up a Docker container for the first time.

Deployment

Docker (Linux)

Deployment Details

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant