-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fastlane] Delete IDFA declarations for Apple App Store submission #22003
base: master
Are you sure you want to change the base?
Conversation
Here is a diff between openapi.1.4.1.json and openapi.3.4.1.json
- "idfaDeclaration",
- "usesIdfa",
- "idfaDeclaration",
- "description": "the fields to include for returned resources of type idfaDeclarations",
- "name": "fields[idfaDeclarations]",
- "idfaDeclaration",
- "usesIdfa",
- "idfaDeclaration",
- "usesIdfa",
- "/v1/appStoreVersions/{id}/idfaDeclaration": {
- "operationId": "appStoreVersions-idfaDeclaration-get_to_one_related",
- "description": "the fields to include for returned resources of type idfaDeclarations",
- "name": "fields[idfaDeclarations]",
- "$ref": "#/components/schemas/IdfaDeclarationResponse"
- "idfaDeclaration",
- "usesIdfa",
- "idfaDeclaration",
- "usesIdfa",
- "description": "the fields to include for returned resources of type idfaDeclarations",
- "name": "fields[idfaDeclarations]",
- "idfaDeclaration",
- "usesIdfa",
- "idfaDeclaration",
- "idfaDeclaration",
- "usesIdfa",
- "idfaDeclaration",
- "usesIdfa",
- "idfaDeclaration",
- "usesIdfa",
- "/v1/idfaDeclarations": {
- "operationId": "idfaDeclarations-create_instance",
- "$ref": "#/components/schemas/IdfaDeclarationCreateRequest"
- "description": "IdfaDeclaration representation",
- "$ref": "#/components/schemas/IdfaDeclarationResponse"
- "description": "Single IdfaDeclaration"
- "IdfaDeclarations"
- "/v1/idfaDeclarations/{id}": {
- "operationId": "idfaDeclarations-delete_instance",
- "IdfaDeclarations"
- "operationId": "idfaDeclarations-update_instance",
- "$ref": "#/components/schemas/IdfaDeclarationUpdateRequest"
- "description": "IdfaDeclaration representation",
- "$ref": "#/components/schemas/IdfaDeclarationResponse"
- "description": "Single IdfaDeclaration"
- "IdfaDeclarations"
- "usesIdfa": {
- "idfaDeclaration": {
- "idfaDeclarations"
- "usesIdfa": {
- "$ref": "#/components/schemas/IdfaDeclaration"
- "usesIdfa": {
- "$ref": "#/components/schemas/IdfaDeclaration"
- "IdfaDeclaration": {
- "idfaDeclarations"
- "title": "IdfaDeclaration",
- "IdfaDeclarationCreateRequest": {
- "idfaDeclarations"
- "title": "IdfaDeclarationCreateRequest",
- "IdfaDeclarationResponse": {
- "$ref": "#/components/schemas/IdfaDeclaration"
- "title": "IdfaDeclarationResponse",
- "IdfaDeclarationUpdateRequest": {
- "idfaDeclarations"
- "title": "IdfaDeclarationUpdateRequest", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for tackling this!
I know you said it's still in progress, but from a quick skim of the diff and what was deleted and cleaned up, this looks good and very promising 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for remembering to also update the docs! 🙇
In case you don't have access to our CircleCI logs to see the test failure, here's the logs of
|
99199a2
to
f8653e1
Compare
Is this going to be merged in soon? I can't submit with fastlane atm. I either get "the specified resource does not exist - The path provided does not match a defined resource type" when add_id_info_uses_idfa is true or Use of Advertising Identifier (IDFA) is required to submit |
@EthanSK you can just remove (This PR is only to clean up what will now be dead code, as people stop using that attribute in their |
This doesn't work because fastlane bails out of the submit if the idfa stuff is missing. It worked for us last release, but now I assume something has changed and the idfa declaration is missing which trips this issue: deliver/lib/deliver/submit_for_review.rb:148 |
Having this exact same issue. |
the PR should be good to go. I have performed several submissions with the IDFA deleted, and it seems OK so far |
Hey @dave-perry and @cooksimo ! submission_information({
...
add_id_info_uses_idfa: false,
...
}) in (in order to unblock you) I've just tried one submission and it seems to work Just for example. This is what I see in logs:
I hope it helps |
Also PR for docs update fastlane/docs#1246 |
It seems to sometimes work and sometimes not. For me as well, the last submission went through without idfa but then it failed recently... |
Feedback addressed @AliSoftware |
Thanks, that worked for me (this week! 😅) |
Question: what happens if you do not update your Deliverfile? Does fastlane fail because the setting doesn't exist? Has this been tested? |
In this PR i've tested that if |
I am afraid removing the parameter is not helping. When I get rid of it then I get another error complaining about the IDFA not present but required. I am blocked because no matter what I do it fails. By the way, removing it was fine in las build, but somehow it does no longer work for us. Anyone else with a similar issue? |
Hey @angelolloqui please could you check if setting param to |
Hey @fr0l , I can try, but it does not make much sense to me putting it to false since we are really using IDFA, so that would basically be "tricking" right? Isn't the real problem here that Apple has changed the API and we need to adapt to the newest? |
Hey @angelolloqui , Although the release notes also say
(which looks like "optional" because of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor change request. Thanks for getting this fixed!
The build failing with the test from Is it possible to re-run the build? |
Hey @angelolloqui , So I guess in this PR it is just deletion of the functionality that was removed from OpenAPI. So the key I'm not sure - what would be good option here - probably to show warning that |
Ok thanks! With your info a tried to put it to false and it worked this time, so I think you are right it must be removed |
Checklist
bundle exec rspec
from the root directory to see all new and existing tests passbundle exec rubocop -a
to ensure the code style is validci/circleci
builds in the "All checks have passed" section of my PR (connect CircleCI to GitHub if not)Motivation and Context
Resolves #21998
Seems Seems that the IDFA-related APIs were deprecated in v1.5 by Apple and finally removed.
The PR is just to delete the deprecated IDFA-related code.
the issue #21998 itself can be mitigated by:
add_id_info_uses_idfa
to falseadd_id_info_uses_idfa
fromDeliverfile
/ call todeliver
methodthe PR is just code removal
Description
Testing Steps