Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move functions from bot.py to cogs.utils #94

Open
eibex opened this issue Dec 1, 2021 · 6 comments
Open

Move functions from bot.py to cogs.utils #94

eibex opened this issue Dec 1, 2021 · 6 comments
Labels
good first issue Good for newcomers refactoring Code refactoring

Comments

@eibex
Copy link
Owner

eibex commented Dec 1, 2021

Move non __init__ functions from bot.py to utils.
This also means updating the function references inside all cogs.

@eibex eibex added good first issue Good for newcomers refactoring Code refactoring labels Dec 1, 2021
@HrutikaBadgeri
Copy link

HrutikaBadgeri commented Jan 27, 2023

I'd like to work on this. Assign me this issue

@eibex
Copy link
Owner Author

eibex commented Jan 29, 2023

Thank you!

@HrutikaBadgeri
Copy link

just a small query, do you want all the non init functions under the same file within same class or should I keep them as separate files?

@eibex
Copy link
Owner Author

eibex commented Jan 31, 2023

I would put the database updates under schema.py (or a separate file if easier for you), report under either errors or a new file (up to you), and the getchannel and similar functions together in a new separate file.

@HrutikaBadgeri
Copy link

okay, I added the codes into the files as per your requirements. can you tell me about the function references part that i'm supposed to change now, since the functions have been moved to different locations.

@Edwinexd
Copy link
Contributor

Edwinexd commented Feb 1, 2023

Hey! Function references in this context would for example mean updating bot.getchannel calls in messages.py to wherever you have placed the getchannel. The gist of it is just make sure that the program still functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers refactoring Code refactoring
Projects
None yet
Development

No branches or pull requests

3 participants