Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header link hardcoded to staging site #251

Closed
mjmaisey opened this issue Oct 12, 2020 · 0 comments · May be fixed by #254
Closed

Header link hardcoded to staging site #251

mjmaisey opened this issue Oct 12, 2020 · 0 comments · May be fixed by #254
Assignees
@xenatisch
Labels
bug Something isn't working

Comments

@mjmaisey
Copy link

mjmaisey commented Oct 12, 2020 •
edited

Describe the bug

The header link of the dashboard takes you to the staging site home (https://coronavirus-staging.data.gov.uk/), not the public site home. This could mean members of the public, press etc. are at random exposed to bugs in unreleased code versions, depending on their navigation path.

To Reproduce

  1. Open https://coronavirus.data.gov.uk/
  2. Click on the black banner at the top
  3. Note the URL is now that of the staging site.

Expected behaviour

The URL should remain https://coronavirus.data.gov.uk/

Screenshots

N/A

Desktop (please complete the following information):

Not OS/browser dependent.

Additional context

The problem was introduced in July and is on line 14 of:
https://github.com/publichealthengland/coronavirus-dashboard/blob/v2-development/src/components/Header/Header.js

which hardcodes an environment-specific URL.
@mjmaisey mjmaisey added the bug Something isn't working label Oct 12, 2020
@joemclo joemclo mentioned this issue Oct 17, 2020
Open
joemclo added a commit to joemclo/coronavirus-dashboard that referenced this issue Oct 17, 2020
@joemclo
On header link redirect to / route rather than hardcoded staging site
73a9f6a 
This commit is a fix for UKHSA-Internal#251.
On the master site https://coronavirus.data.gov.uk/ the main header
redirects to https://coronavirus-staging.data.gov.uk/

On the staging site https://coronavirus-staging.data.gov.uk/ the main
header redirects to https://coronavirus.data.gov.uk/

I'm assuming this is not intentional and is a bug, and set the header
link to redirect to / route, so that on whatever site this project is
deployed, it will always redirect to the base index page.
@joemclo joemclo mentioned this issue Oct 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xenatisch xenatisch

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

On header link redirect to / route rather than hardcoded staging site joemclo/coronavirus-dashboard
2 participants
@mjmaisey @xenatisch