Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up arm job when run again #3532

Closed
wolfgangwalther opened this issue May 17, 2024 · 2 comments
Closed

Clean up arm job when run again #3532

wolfgangwalther opened this issue May 17, 2024 · 2 comments
Labels
ci Related to CI setup

Comments

@wolfgangwalther
Copy link
Member

The following scenario just happend:

  • The arm job failed on main
  • The cleanup job still ran, because it's always running
  • I triggered a re-run of arm

Now.. the cleanup will not happen anymore, so the build directory will be kept forever.

@wolfgangwalther wolfgangwalther added the ci Related to CI setup label May 17, 2024
@laurenceisla
Copy link
Member

laurenceisla commented May 17, 2024

Ah, so something like this?

1st CI run: Arm build ❌ -> Clean up job ✅
2nd CI run: Arm build ✅ -> Clean up job 🚫

But I think the cleanup still ran, there's no directory in the server right now, or did you delete it manually? It should still trigger when it's rerun due to the dependency.

@wolfgangwalther
Copy link
Member Author

It should still trigger when it's rerun due to the dependency.

Ah, that could in fact be true. I didn't really observe this, it was more of an assumption. When I triggered the re-run of the failed job via "run all failed jobs", I assumed the already passed cleanup job wouldn't run again.

But I think the cleanup still ran, there's no directory in the server right now

Thanks for confirming.

@wolfgangwalther wolfgangwalther closed this as not planned Won't fix, can't repro, duplicate, stale May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Related to CI setup
Development

No branches or pull requests

2 participants