Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .pre-commit-config.yaml and use pre-commit to run the various linters, formatters, and checks #3159

Open
yelircaasi opened this issue Nov 8, 2023 · 1 comment

Comments

@yelircaasi
Copy link

pre-commit is a tremendous project that has greatly improved my workflow - easy to install and easy to use. I would be happy to implement it here and open a pull request, I just wanted to see first if that is something people would be on board with. Its benefits are twofold - firstly, it ensures code standards are met before each commit. Secondly, it provides an easy command to run all relevant linters etc. at any point during the development process.

@kantord
Copy link
Owner

kantord commented Nov 14, 2023

pre-commit is a tremendous project that has greatly improved my workflow - easy to install and easy to use. I would be happy to implement it here and open a pull request, I just wanted to see first if that is something people would be on board with. Its benefits are twofold - firstly, it ensures code standards are met before each commit. Secondly, it provides an easy command to run all relevant linters etc. at any point during the development process.

yes, this would be amazing. I am also already using pre-commit in some other project and I can attest that it is amazing, so a PR is definitely welcome!

Also I think in the config file, I think the linting/formatting tools could be replace with https://github.com/astral-sh/ruff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants