Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make YAML loader be able to report multiple problems at once #2795

Open
kantord opened this issue Apr 2, 2023 · 1 comment
Open

Make YAML loader be able to report multiple problems at once #2795

kantord opened this issue Apr 2, 2023 · 1 comment

Comments

@kantord
Copy link
Owner

kantord commented Apr 2, 2023

Right now, there is a problem: the YAML loader fails at the first serious error, and does not attempt to analyze more files from the project.

This leads to annoying problems because - especially in the early stages of a course - people might be editing a lot of files at once and there could be a lot of problems present all at the same time. This will become extra annoying when the user realizes that after fixing a problem, a new problem will appear, and this process will be repeated until all problems are gone. There could be a large number of problems, and it could become overwhelming as without being able to see all problems at once, this can become overwhelming.

In order to avoid this issue we should change the YAML loader so that all problems are detected in one go, at least when this is technically possible.

@kantord
Copy link
Owner Author

kantord commented Apr 2, 2023

One easy gain here could be, after the JSON schema validation is fully implemented, to validate all JSON files in one go in the beginning: #2438

That should be nearly trivial to solve.

Probably the majority of other errors is related to the mini-dictionary. That could require revamping how the analysis of courses and the handling of mini dictionaries is solved. The logic could be changed in a way so that first, all data can be loaded without analyzing the mini-dictionary. Then all errors not related to the mini dictionary could be reported here. After that, the handling of the mini dictionary could be implemented in such a way that all errors are reported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant