Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove any peerDependencies on packages other than hub-common #655

Open
2 tasks
tomwayson opened this issue Sep 30, 2021 · 1 comment
Open
2 tasks

remove any peerDependencies on packages other than hub-common #655

tomwayson opened this issue Sep 30, 2021 · 1 comment

Comments

@tomwayson
Copy link
Member

Fortunately it looks like it's just sites that has peerDependences on initiatives and teams.

That causes:

  • us to have to keep those peerDependencies up to date manually at release time
  • solution.js to depend on teams and initiatives even though it doesn't use them,
  • solution.js maintainers to rely on often ignored console messages to know if they need to update teams or initiatives

Proposed solution:

  • move getInitiativeTemplate(), addInitiative(), updateInitiativeSiteId() (and any fns they need) to common
  • consolidate teams into common since it is relatively small and we'll want to do this for most if not all packages
@tomwayson
Copy link
Member Author

NOTE: the above is true of teams in template-js too.

Furthermore, the processors package only depends on initiatives for getUniqueGroupName(), so maybe that can move to common too at this juncture and then template-js can drop the dependencies on both teams and initiatives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant