Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tests using URL placeholder images to use the placeholderImage utility function #9361

Closed
driskull opened this issue May 17, 2024 · 2 comments
Closed

Update tests using URL placeholder images to use the placeholderImage utility function #9361

driskull opened this issue May 17, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. p - low Issue is non core or affecting less that 10% of people using the library testing Issues related to automated or manual testing.
Milestone
2024-05-28 - May ...

Comments

@driskull
Copy link
Member

Priority impact

p - low

Test type

Update test

Which Component(s)

Carousel, custom-theme-stories.

Unstable Tests

Anything with placebear or palcem.at

Test error, if applicable

<style>
      .bg-image-example {
        color: red;
        background-image: url("https://placebear.com/3000/2000");
        background-size: cover;
        padding: 1rem;
        height: 300px;
        font-size: 32px;
        font-weight: 600;
        line-height: 32px;
      }
    </style>

PR skipped, if applicable

Additional Info

No response
@driskull driskull added testing Issues related to automated or manual testing. 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels May 17, 2024
@github-actions github-actions bot added the p - low Issue is non core or affecting less that 10% of people using the library label May 17, 2024
@macandcheese macandcheese self-assigned this May 17, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels May 17, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label May 17, 2024
@macandcheese macandcheese removed their assignment May 22, 2024
@macandcheese macandcheese added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels May 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@macandcheese macandcheese mentioned this issue May 22, 2024
Merged
macandcheese added a commit that referenced this issue May 22, 2024
@macandcheese
chore: Update placeholder images in stories and demos (#9395)
d294d1d 
**Related Issue:** #9361 , #9392 

## Summary
Removes served images from stories and local demo. We keep them in `.md`
file, as these need to be hosted somewhere in order to work if the
samples are used in an external location. cc @driskull

Ideally, we could use map tiles or something
(https://codepen.io/mac_and_cheese/pen/XWwXXqx?editors=1000) for these,
but not sure how reliable those are.
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels May 23, 2024
@geospatialem
Copy link
Member

Verified on the main branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. p - low Issue is non core or affecting less that 10% of people using the library testing Issues related to automated or manual testing.
Projects
None yet
Milestone
2024-05-28 - May Main Release
Development

No branches or pull requests
4 participants
@driskull @macandcheese @geospatialem @DitwanP