Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dropdown Group] The group-tile scale is not scaling with the dropdown scale #9350

Closed
2 of 8 tasks
geospatialem opened this issue May 15, 2024 · 2 comments
Closed
2 of 8 tasks

[Dropdown Group] The group-tile scale is not scaling with the dropdown scale #9350

geospatialem opened this issue May 15, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library regression Issues that are caused by changes in a release, but were working before that.
Milestone
2024-05-28 - May ...

Comments

@geospatialem
Copy link
Member

Check existing issues

Actual Behavior

dropdown-group is not inheriting its parent, dropdown scale and a regression surfaced as a result of no screenshots available for the component's scales.

image

Expected Behavior

Inheritance from the parent dropdown, similar to what is depicted in 1.6.1:

image

The fix should include:

  • Inheritance from the parent dropdown
  • Include screenshots that depict dropdown across all three scales ("s", "m", and "l") for future support.

Reproduction Sample

https://codepen.io/ashetland/pen/mdYeeJQ

Reproduction Steps

  1. Open the sample
  2. Observe the scales are not respecting the dropdown-group's group-tile

Reproduction Version

1.7.0

Relevant Info

Likely as a result of a regression from 1.6.1 via PR #7582.

Regression?

1.6.1

Priority impact

p3 - want for upcoming milestone

Impact

Medium-ish, in particular with additional dropdown design considerations.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@geospatialem geospatialem added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. p - medium Issue is non core or affecting less that 60% of people using the library labels May 15, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. p3 - want for upcoming milestone Calcite (design) Issues logged by Calcite designers. labels May 15, 2024
@anveshmekala anveshmekala added the estimate - 3 A day or two of work, likely requires updates to tests. label May 15, 2024
@ashetland ashetland added the regression Issues that are caused by changes in a release, but were working before that. label May 15, 2024
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label May 15, 2024
@geospatialem geospatialem added this to the 2024-07-30 - Jul Release milestone May 15, 2024
@anveshmekala anveshmekala self-assigned this May 17, 2024
@anveshmekala anveshmekala added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels May 17, 2024
@geospatialem geospatialem added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone and removed p3 - want for upcoming milestone labels May 21, 2024
@anveshmekala anveshmekala mentioned this issue May 23, 2024
Merged
anveshmekala added a commit that referenced this issue May 23, 2024
@anveshmekala
fix(dropdown-group): title scale with dropdown scale (#9360)
3529cdd 
**Related Issue:** #9350

## Summary

`calcite-dropdown-group` title font-size scales with dropdown scale.
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels May 23, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned anveshmekala May 23, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels May 23, 2024
@geospatialem
Copy link
Member Author

Verified in 2.9.0-next.22

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - medium Issue is non core or affecting less that 60% of people using the library regression Issues that are caused by changes in a release, but were working before that.
Projects
None yet
Milestone
2024-05-28 - May Main Release
Development

No branches or pull requests
4 participants
@geospatialem @DitwanP @anveshmekala @ashetland