Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Research a way to share markup between demo.html and "allVariants" story HTML #9313

Open
eriklharper opened this issue May 10, 2024 · 1 comment
Open

Research a way to share markup between demo.html and "allVariants" story HTML #9313

eriklharper opened this issue May 10, 2024 · 1 comment
Assignees
@eriklharper
Labels
1 - assigned Issues that are assigned to a sprint and a team member. p - low Issue is non core or affecting less that 10% of people using the library spike Issues that cannot be estimated well enough until the team has done further research
Milestone
2024-07-30 - Jul ...

Comments

@eriklharper
Copy link
Contributor

eriklharper commented May 10, 2024 •
edited

Background

Spurred by a comment left on #9288 here:

Sidebar: it looks like the content for tile-group and the allVariants story is the same. We should look to see if there's a way of referencing this one from the story or finding a way to use storybook with the Stencil dev server.

Originally posted by @jcfranco in #9288 (comment)

Desired Outcome

  1. Research a way to make this work with a shared export file that both a component's demo.html and stories.ts file can reference so that the both can stay in sync from a single source of truth
  2. Document the pattern and add utils if necessary to aid.
@eriklharper eriklharper added 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. spike Issues that cannot be estimated well enough until the team has done further research labels May 10, 2024
@eriklharper eriklharper mentioned this issue May 10, 2024
Merged
@eriklharper eriklharper self-assigned this May 10, 2024
@eriklharper eriklharper added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels May 10, 2024
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label May 13, 2024
@geospatialem geospatialem removed this from the 2024-05-28 - May Main Release milestone May 13, 2024
@geospatialem geospatialem added needs triage Planning workflow - pending design/dev review. p - low Issue is non core or affecting less that 10% of people using the library needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels May 13, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label May 20, 2024
@geospatialem geospatialem added this to the 2024-07-30 - Jul Release milestone May 20, 2024
@jcfranco
Copy link
Member

@eriklharper Let's target July for this! 💪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eriklharper eriklharper

Labels
1 - assigned Issues that are assigned to a sprint and a team member. p - low Issue is non core or affecting less that 10% of people using the library spike Issues that cannot be estimated well enough until the team has done further research
Projects
None yet
Milestone
2024-07-30 - Jul Release
Development

No branches or pull requests
3 participants
@jcfranco @eriklharper @geospatialem