Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input-time-zone with empty string not defaulting to local time zone #9292

Open
2 of 6 tasks
nwhittaker opened this issue May 9, 2024 · 0 comments
Open
2 of 6 tasks
Labels
0 - new New issues that need assignment. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - medium Issue is non core or affecting less that 60% of people using the library

Comments

@nwhittaker
Copy link
Contributor

Check existing issues

Actual Behavior

Given an input-time-zone with a value of undefined, the user's local time zone is automatically selected. However, given an input-time-zone with an empty string value, the UTC time zone is automatically selected.

Expected Behavior

Given a non-clearable input-time-zone with an empty string value, the user's local time zone is automatically selected.

Reproduction Sample

https://codepen.io/nwhittaker-esri/pen/ZENEKJe

Reproduction Steps

  1. Visit the sample and observe the two input-time-zone elements
  2. The value of the input-time-zone labeled "Empty string value" should match the value of the input-time-zone labeled "Undefined value"

Reproduction Version

2.8.0

Relevant Info

If no value is provided, the user's time zone offset will be selected by default.

Per the doc page ☝️. I suppose this issue is assuming an empty string counts as "no value".

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

Represents some added debugging time and code complexity to the consumer to normalize the "empty" value that's passed into the input-time-zone.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Field Apps

@nwhittaker nwhittaker added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels May 9, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. labels May 9, 2024
@jcfranco jcfranco added p - medium Issue is non core or affecting less that 60% of people using the library estimate - 2 Small fix or update, may require updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Development

No branches or pull requests

2 participants