Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Item - make it more obvious when drag-disabled #9283

Open
2 of 6 tasks
asangma opened this issue May 7, 2024 · 5 comments
Open
2 of 6 tasks

List Item - make it more obvious when drag-disabled #9283

asangma opened this issue May 7, 2024 · 5 comments
Labels
0 - new New issues that need assignment. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs triage Planning workflow - pending design/dev review.

Comments

@asangma
Copy link
Contributor

asangma commented May 7, 2024

Check existing issues

Description

ListItem has drag-disabled. This is good, but there are cases when the drag will never be enabled. In those cases it would be a better UX if the drag-handle were not rendered or at least were rendered with even lower opacity.

I propose to be able to hide the handle when drag-disabled or reduce the opacity of a disabled handle more.

In this example, the child items may never need drag and drop while the parent would regularly need drag.

image

cc @driskull

Acceptance Criteria

Retain the disabled state.
Add "hide" option.

Relevant Info

No response

Which Component

ListItem

Example Use Case

CatalogLayer. Because the structure of this layer type, its children may never need drag and drop.

Priority impact

p3 - want for upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript

@asangma asangma added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels May 7, 2024
@github-actions github-actions bot added ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. p3 - want for upcoming milestone labels May 7, 2024
@asangma asangma closed this as completed May 9, 2024
@asangma asangma reopened this May 17, 2024
@asangma
Copy link
Contributor Author

asangma commented May 17, 2024

Reopening this.
Based on implementation in our JS SDK for LayerList, it would still be useful to selectively turn off the drag handle for specific ListItems in a List that has drag-enabled.

@asangma
Copy link
Contributor Author

asangma commented May 17, 2024

In this example, there are two items that whose dragging cannot be enabled. While the handles are disabled, the lowered opacity doesn't provide a great amount of contrast.

image

@asangma asangma changed the title List Item - add ability to hide drag-handle when drag-disabled List Item - make it more obvious when drag-disabled May 17, 2024
@asangma
Copy link
Contributor Author

asangma commented May 17, 2024

Lower opacity (0.25)
image

Icon set to blank
image

@driskull driskull added the design Issues that need design consultation prior to development. label May 17, 2024
@driskull
Copy link
Member

This would be for design to consider. Added the label

@asangma
Copy link
Contributor Author

asangma commented May 17, 2024

Thanks @driskull. 🤘🏾

@geospatialem geospatialem added impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone and removed p3 - want for upcoming milestone labels May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

3 participants