Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FloorFilter - NavigationStack incompatibility #706

Open
dfeinzimer opened this issue Apr 29, 2024 · 0 comments
Open

FloorFilter - NavigationStack incompatibility #706

dfeinzimer opened this issue Apr 29, 2024 · 0 comments
Labels
bug Something isn't working Effort - medium A medium level of effort to complete Priority - high A high-priority item

Comments

@dfeinzimer
Copy link
Collaborator

dfeinzimer commented Apr 29, 2024

As of 694, the Floor Filter is broken when used within a NavigationStack. This problem was revealed when the test runner switched from a NavigationView to a NavigationStack in 695.

The Floor Filter uses its own NavigationStack internally. Previously, with the deprecated NavigationView this wasn't an issue. Nested NavigationStacks break patterns we've relied upon:

    1. The filter's view model is no longer available in the environment.
    1. If we work around (i) by passing the model directly via parameters we run into the next problem: The facility list seems to loose the filter's NavigationStack and is instead drawn into the user level NavigationStack. The items in the navigation bar (title, back & close buttons, filter) are also moved.
brokenFloorFilter.mov
@dfeinzimer dfeinzimer added the bug Something isn't working label Apr 29, 2024
@dfeinzimer dfeinzimer added Effort - medium A medium level of effort to complete Priority - high A high-priority item labels Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Effort - medium A medium level of effort to complete Priority - high A high-priority item
Projects
None yet
Development

No branches or pull requests

1 participant