Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localized string constants are stored when they should be computed #527

Open
philium opened this issue Nov 30, 2023 · 1 comment
Open

Localized string constants are stored when they should be computed #527

philium opened this issue Nov 30, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@philium
Copy link
Contributor

philium commented Nov 30, 2023

Because a localized string is based on a locale and the locale can change while the app is running, localized string "constants" should be computed, not stored. In some places, like this extension, the localized strings are stored as static properties, meaning that they won't change if that app's locale were to change. All static localized strings should be converted from stored to computed.

@philium philium added the bug Something isn't working label Nov 30, 2023
@mhdostal
Copy link
Member

mhdostal commented Dec 1, 2023

@philium Thanks for noticing that!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants