-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inflexible PopupViewer #514
Comments
@dotMorten @mbranscomb There appears to be some newly introduced issues with the new PopupViewer. PS. forgive my less serious avatar, as the account was created for internal development. |
@bsundsbo We're mainly using the popup templates defined in the webmapping spec. You'd have to use Arcade to create a more custom definition of your table to support the scenario. With Arcade you should be able to conditionalize certain content. |
Do you have some examples of this, and how a popup definition differs in the toolkit compared to for instance the online webmap viewer? |
The toolkit looks the same as the online webmap viewer. In the previous version of the toolkit I could create my own styles per "row"/attribute set so that I could hide it when the value was null/empty. In the new toolkit I only have access to either the fieldname/display name or the value; not both, so no longer able to hide the label/value pair. |
I'll see if my team member can create a comparison of the toolkit vs web viewer |
It would be very nice to keep the ability to style according to the target application, rather than forced to style the same as the webviewer. I know you can change the font and row color, but more flexibility would be nice. Default appearance makes sense to match the webviewer. |
I had a conversation with my coworker, and it turns out there was some confusing and not knowing the applications well enough to do the sort of configuration. The field order, display name and visibility was reflected the toolkit. However, the limitation to have to use a table view (not super important for us, but might be relevant for others) and be able to set a property to true to rows with empty values would be very beneficial, without having to use Arcade. |
@dotMorten I would create some pull requests for the features I need, however, I'm having problems compiling the toolkit.
|
The design is meant to match the arcgis online popup viewer by default. Hyperlink events is a good suggestion - we already do something similar for attachments clicked (which allow you to override the default open action). We do have plans to add localization to the toolkit - will that take care of the hyperlink text?
What problems are you having? We keep this open source so you can adjust it for your own uses. We realize it's not possible to build a lot of UI controls that fits every single scenario, so we want our customers to be able to fork and customize for their specific scenarios. |
About Compiler errors
|
Looks like restore errors after pulling latest. Try on a fresh clone or make sure all /bin/ and /obj/ folder has been deleted and restart VS. |
Inactive - please reopen if still an issue with 200.4 |
Hi,
In the 200.1 update of PopupViewer, the customization of the table is a bit of a hassle when it comes to individual fields. We wanted to take advantage of the new features of the control. We don't want to display attributes with empty values, and since the table is generated in code-behind, we are not able to set any visibility of a particular row. At least an option to hide empty value rows would be helpful.
However, I feel the new design is a bit rigid, as it requires a table format. The previous version was a bit more flexible in case you want i.e. label over value.
It appears that the new PopupViewer PopupViewer ignores hidden fields, changes to displayname for fields and order configured in the webmap.
The text was updated successfully, but these errors were encountered: