Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Default translationValue to english value if empty #729

Open
1 task
ngiangre opened this issue Jun 6, 2020 · 1 comment
Open
1 task

[FEAT] Default translationValue to english value if empty #729

ngiangre opened this issue Jun 6, 2020 · 1 comment

Comments

@ngiangre
Copy link
Contributor

ngiangre commented Jun 6, 2020

⚠️ IMPORTANT: Please fill out this template to give us as much information as possible to consider/implement the feature.

Prerequisites

  • check this box if you have completed the following:
    • Reviewed the contributing guidelines and support files
    • Reviewed the README file for the repository you are working in
    • Searched for relevant instructions on our Discord server
    • Searched the issues of the repository you are working in to make sure one was not already filed

Summary

If the translation of text hasn't be added by a translator, the resulting value will be empty. In this case, the value should instead be the english value so that the key can be used by i18next while indicating there needs to be a translation of the text.

Motivation

When the app is in a non-english locale, there needs to be a translation provided and if not, a way to signal the translation needs to be added. This signal can be the text in english.

Possible Alternatives

Nothing shows up so debugging is more difficult.

Additional Context

pull_gsheets_translations_mvp.py needs to be updated with a conditional. If the translatedValue is empty, replace with the english value.

@pavel-ilin
Copy link

I can work on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants